-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NEW] Rocket.cat message for users when an app previously requested is installed #27672
Conversation
…an app is installed
…cketChat/Rocket.Chat into feat/install-app-request-notification
Codecov Report
@@ Coverage Diff @@
## develop #27672 +/- ##
===========================================
+ Coverage 41.46% 42.24% +0.78%
===========================================
Files 841 814 -27
Lines 17701 17189 -512
Branches 1996 1921 -75
===========================================
- Hits 7339 7262 -77
+ Misses 10119 9687 -432
+ Partials 243 240 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I'd like to see this moved to 12 hours instead of 24 hours, that way there isn't too long of a delay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from the Marketplace perspective.
Proposed changes (including videos or screenshots)
This PR adds a new cronjob to notify end-users that an app they requested is now enabled. The cronjob is scheduled to run every 24 hours after the workspace started. I'm using this strategy to avoid many workspaces hitting marketplace-api at the same time.
Also, worth to mention, this long polling strategy was chosen as we can have many users waiting for notifications, so it's a process-heavy task that it's better to do in the background.
Issue(s)
Task
Steps to test or reproduce
Right now, it's only possible to add app requests through the marketplace API. So, we need to wait for the final version of apps requests to land in staging to staging testing properly.
Further comments