-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Unintended "Reply on thread" button showing on thread's first message #27716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27716 +/- ##
===========================================
+ Coverage 41.93% 42.88% +0.94%
===========================================
Files 845 818 -27
Lines 17799 17282 -517
Branches 2019 1944 -75
===========================================
- Hits 7464 7411 -53
+ Misses 10069 9607 -462
+ Partials 266 264 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Hi @Educg550 we have a method called |
Educg550
commented
Jan 12, 2023
Educg550
commented
Jan 12, 2023
hugocostadev
requested changes
Jan 13, 2023
Closed
hugocostadev
previously approved these changes
Jan 13, 2023
hugocostadev
requested changes
Jan 17, 2023
hugocostadev
approved these changes
Jan 17, 2023
tassoevan
approved these changes
Jan 17, 2023
dionisio-bot
bot
added
the
stat: ready to merge
PR tested and approved waiting for merge
label
Jan 24, 2023
Educg550
changed the title
[FIX] Unintended "Reply on thread" button won't show anymore for any messages inside a thread
[FIX] Unintended "Reply on thread" button showing on thread's first message
Jan 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Referent to TC-128
Before:
After:
Issue(s)
Steps to test or reproduce
Open a new channel, then:
Further comments
As flagged in comment on that issue, seems that there was a discussion whether the thread should open again or have a new created one when clicking on such unintended button. That said, it's conclusive to say that there was no point on opening a new thread for the top message when you're already on one, same for opening new threads for further messages.