Regression: Add support for 2FA errors to Meteor.callAsync
#27767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #27767 +/- ##
===========================================
+ Coverage 42.01% 42.06% +0.04%
===========================================
Files 844 845 +1
Lines 17751 17783 +32
Branches 2009 2019 +10
===========================================
+ Hits 7458 7480 +22
- Misses 10029 10034 +5
- Partials 264 269 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
reviewed
Jan 17, 2023
Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
ggazzo
reviewed
Jan 17, 2023
ggazzo
reviewed
Jan 17, 2023
ggazzo
approved these changes
Jan 17, 2023
dionisio-bot
bot
added
stat: ready to merge
gabriellsh
added a commit
that referenced
this pull request
Jan 23, 2023
…etChat/Rocket.Chat into matrixSearch * 'feat/federation-search-public-rooms' of github.com:RocketChat/Rocket.Chat: Chore: Move service shutdown logic to each service (#27690) Chore: change colors to dark theme on Marketplace (#27532) Chore: Update color tokens (#27704) Chore: Remove medium prop from ButtonGroup (#27784) Regression: Add support for 2FA errors to `Meteor.callAsync` (#27767) [NEW] Attachment Files Redesign (#27470) [FIX] App page showing version undefined for apps not in marketplace (#27766) Chore: Add surface-light background to AppRow (#27765)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Since #27639 , when
callMethodwas changed to useMeteor.callAsyncinstead ofMeteor.call, 2FA flow was not working.Issue(s)
Steps to test or reproduce
Further comments