Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add hint (description) to CodeSettingInput after label #27843

Merged
merged 3 commits into from
Feb 7, 2023

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Jan 25, 2023

Proposed changes (including videos or screenshots)

  • Added hint (description) to CodeSettingInput after label
  • Created a storybook story for that scenario
  • add a checker to not add hint to<MemoizedSetting /> if the inputType is code

Before:
image

After:
image

Issue(s)

Steps to test or reproduce

Further comments

TC-381

@hugocostadev hugocostadev requested a review from a team as a code owner January 25, 2023 13:29
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #27843 (08e13da) into develop (e6279ad) will increase coverage by 0.87%.
The diff coverage is n/a.

❗ Current head 08e13da differs from pull request most recent head ce38a38. Consider uploading reports for the commit ce38a38 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #27843      +/-   ##
===========================================
+ Coverage    42.02%   42.90%   +0.87%     
===========================================
  Files          846      818      -28     
  Lines        17546    17282     -264     
  Branches      2078     1944     -134     
===========================================
+ Hits          7373     7414      +41     
+ Misses        9891     9604     -287     
+ Partials       282      264      -18     
Flag Coverage Δ
e2e 42.90% <ø> (+0.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Feb 7, 2023
@kodiakhq kodiakhq bot merged commit 5f3f001 into develop Feb 7, 2023
@kodiakhq kodiakhq bot deleted the chore/hint-position branch February 7, 2023 14:39
@alvaropmello alvaropmello added this to the 6.0.0 milestone Feb 14, 2023
@sampaiodiego sampaiodiego mentioned this pull request Feb 17, 2023
@sampaiodiego sampaiodiego mentioned this pull request Mar 9, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants