[FIX] Empty DMs go to sidebar's top after updating user preferences #27912
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
_updatedAt
aslm
field when merging info from subscriptions and rooms (since this field is updated along with the user preferences).Issue(s)
Fix #23617
Steps to test or reproduce
Current behavior: empty DMs go to the top of the list.
Expected behavior: empty DMs should now stay at the bottom of the list.
Further comments
The
lastRoomUpdate
variable is used as a backup field to thelm
field when it is not available in the room (that is, when no message has been sent in the room). Changing user notification preferences also updates the_updatedAt
field in every subscription, which implies that empty DMs will be sorted to top when the sidebar is sorted. Instead, we could keep this field as undefined so that they're sorted to the bottom of the list.TC-79