[BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only #27969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigok
reviewed
Feb 10, 2023
# Conflicts: # apps/meteor/server/startup/instance.ts # apps/meteor/server/stream/streamBroadcast.js
rodrigok
force-pushed
the
new-matrix-broadcast
branch
2 times, most recently
from
b793b8d
to
612edb7
Compare
rodrigok
force-pushed
the
new-matrix-broadcast
branch
from
612edb7
to
3dba945
Compare
rodrigok
changed the title
…hat into new-matrix-broadcast
dionisio-bot
bot
added
the
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #27969 +/- ##
===========================================
+ Coverage 41.66% 42.64% +0.98%
===========================================
Files 834 806 -28
Lines 17285 16622 -663
Branches 2068 1993 -75
===========================================
- Hits 7202 7089 -113
+ Misses 9811 9261 -550
Partials 272 272
Flags with carried forward coverage won't be shown. Click here to find out more. |
rodrigok
approved these changes
Feb 13, 2023
ggazzo
approved these changes
Feb 13, 2023
ggazzo
changed the title
gabriellsh
added a commit
that referenced
this pull request
Feb 13, 2023
…e/wizard * 'develop' of github.com:RocketChat/Rocket.Chat: [BREAK] Unify monolith and microservices intercommunication on same technology and limit to Enterprise only (#27969) [NEW] Emojis rendering properly on quote message previews (#27972) Chore: Wait message to not be Busy (#28000) Chore: e2e changes tests (#27987) [IMPROVE] Audit (#27994) [IMPROVE] Registration Experience (#27820) [BREAK][ENTERPRISE] Limit presence statuses to 200 concurrent users when running monolith to keep performance (#27854) [BREAK] Removed deprecated settings for Legacy Messages, Marked, Snippet Messages, Autolinker and IssueLinks (#27902) [NEW] Permission to bypass message editing and removing limits (#27644) [FIX] Video Conf Message Blocks not always updating when running on micro services (#27764) Chore: Set missing colors (#27817) Fix CI Chore: undo busy selector [BREAK] Remove message view mode from User Preferences (#27867) Chore: Aria busy indicators (#27978) Chore: Refactor Composer Dropdown (#27931) Chore: Added Enterprise Options to Login customization (#27855) [FIX] Ignored messages reactivity (#27279) [BREAK] [NEW] Custom roles upsell modal (#27707)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This change removes the old DDP Matrix communication by Moleculer based breaker over TCP, simplifying code maintenance, allowing better reliability, performance and monitoring.
It requires a license to enable communication among servers as the rest of the Moleculer implementation.
Community Edition will loose ephemeral events as Typing indication and others when running multiple instances.
Issue(s)
Steps to test or reproduce
Further comments
It's still missing to implement the ability to disable matrix broadcast via existing setting.