Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Fix presence broadcast not re-enabling #28017

Merged
merged 6 commits into from
Feb 17, 2023
Merged

Conversation

sampaiodiego
Copy link
Member

Proposed changes (including videos or screenshots)

Turns out blocked settings cannot have the value changed, which makes sense, but for the presence broadcast status setting we need it to be changed, just not from the UI. I chose to use blocked because readonly was not having any effect on the UI, but brought this downside.

So I'm now fixing readonly boolean settings in the UI, by making them disabled, this allowed changing the setting back to readonly 😉

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego requested a review from a team as a code owner February 13, 2023 17:40
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 13, 2023
rodrigok
rodrigok previously approved these changes Feb 13, 2023
ggazzo
ggazzo previously approved these changes Feb 13, 2023
@sampaiodiego sampaiodiego dismissed stale reviews from ggazzo and rodrigok via 4dbf5d0 February 13, 2023 21:38
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #28017 (8f958d7) into develop (f34efb1) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28017      +/-   ##
===========================================
+ Coverage    43.97%   44.04%   +0.07%     
===========================================
  Files          792      792              
  Lines        15349    15349              
  Branches      2110     2110              
===========================================
+ Hits          6749     6761      +12     
+ Misses        8318     8298      -20     
- Partials       282      290       +8     
Flag Coverage Δ
e2e 44.04% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo merged commit b51d352 into develop Feb 17, 2023
@ggazzo ggazzo deleted the presence-regression branch February 17, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants