Regression: Fix presence broadcast not re-enabling #28017
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Turns out
blocked
settings cannot have thevalue
changed, which makes sense, but for the presence broadcast status setting we need it to be changed, just not from the UI. I chose to useblocked
becausereadonly
was not having any effect on the UI, but brought this downside.So I'm now fixing
readonly
boolean settings in the UI, by making themdisabled
, this allowed changing the setting back toreadonly
😉Issue(s)
Steps to test or reproduce
Further comments