Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: Change default Docker flavor to Alpine #28042

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Feb 14, 2023

ARCH-1305

Proposed changes (including videos or screenshots)

Previously we were shipping Alpine as an alternative flavor under the tag rocketchat/rocket.chat:{release}.alpine , we have been testing this for a while now so we're migrating to use the official one to Alpine.

We'll still ship a Debian variant under the tag rocketchat/rocket.chat:{release}.debian.

Issue(s)

Steps to test or reproduce

Further comments

@sampaiodiego sampaiodiego added this to the 6.0.0 milestone Feb 14, 2023
@sampaiodiego sampaiodiego requested a review from a team as a code owner February 14, 2023 20:13
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: needs QA labels Feb 14, 2023
@sampaiodiego sampaiodiego marked this pull request as draft February 14, 2023 20:22
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (34ed9ad) to head (ef9a16b).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #28042   +/-   ##
========================================
  Coverage    74.88%   74.88%           
========================================
  Files          473      473           
  Lines        20810    20810           
  Branches      5314     5314           
========================================
  Hits         15583    15583           
  Misses        4602     4602           
  Partials       625      625           
Flag Coverage Δ
unit 74.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego removed this from the 6.0.0 milestone Feb 15, 2023
@sampaiodiego
Copy link
Member Author

aborting this one for now as we still have dependencies on federation that don't work on Alpine

@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Feb 16, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Feb 16, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@ggazzo ggazzo changed the title [BREAK] Change default Docker flavor to Alpine chore!: Change default Docker flavor to Alpine Oct 18, 2024
Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dionisio-bot dionisio-bot bot added stat: QA assured Means it has been tested and approved by a company insider and removed stat: QA skipped labels Oct 18, 2024
@ggazzo ggazzo force-pushed the change-official-docker-to-alpine branch from 882e1a3 to 08e2f1c Compare October 18, 2024 19:19
Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: e25b972

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 33 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggazzo ggazzo marked this pull request as ready for review October 18, 2024 19:37
@ggazzo ggazzo requested a review from a team as a code owner October 18, 2024 19:37
@ggazzo ggazzo force-pushed the change-official-docker-to-alpine branch from 89cdce9 to ccb1460 Compare October 18, 2024 20:24
Copy link
Contributor

github-actions bot commented Oct 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-28042/
on branch gh-pages at 2024-10-18 21:43 UTC

@ggazzo ggazzo added this to the 7.0 milestone Oct 18, 2024
@ggazzo ggazzo force-pushed the change-official-docker-to-alpine branch from f278c0c to ef9a16b Compare October 18, 2024 21:30
ggazzo
ggazzo previously approved these changes Oct 18, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@ggazzo ggazzo merged commit 274a89b into develop Oct 18, 2024
4 of 5 checks passed
@ggazzo ggazzo deleted the change-official-docker-to-alpine branch October 18, 2024 22:12
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants