Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: OAuth Login #28303

Merged
merged 10 commits into from
Mar 8, 2023
Merged

Regression: OAuth Login #28303

merged 10 commits into from
Mar 8, 2023

Conversation

d-gubert
Copy link
Member

@d-gubert d-gubert commented Mar 7, 2023 •
edited
Loading

Proposed changes (including videos or screenshots)

Login flow with Rocket.Chat as an OAuth provider was broken

Issue(s)

Steps to test or reproduce

Further comments

AE-108

@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Merging #28303 (0d9afb0) into develop (e78bd95) will increase coverage by 11.98%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #28303       +/-   ##
============================================
+ Coverage    32.88%   44.86%   +11.98%     
============================================
  Files          648      771      +123     
  Lines        12874    14979     +2105     
  Branches      1857     2092      +235     
============================================
+ Hits          4233     6721     +2488     
+ Misses        8433     7961      -472     
- Partials       208      297       +89
Flag Coverage Δ
e2e 44.82% <ø> (+11.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo marked this pull request as ready for review March 8, 2023 00:38
@ggazzo ggazzo requested review from a team as code owners March 8, 2023 00:38
@ggazzo
Copy link
Member

ggazzo commented Mar 8, 2023

DID

@ggazzo ggazzo dismissed sampaiodiego’s stale review March 8, 2023 00:42

did not diding well

@ggazzo ggazzo changed the title Regression: OAuth apps Regression: OAuth Login Mar 8, 2023
@d-gubert d-gubert added this to the 6.0.0 milestone Mar 8, 2023
@d-gubert d-gubert requested review from ggazzo and sampaiodiego March 8, 2023 01:50
@ggazzo ggazzo added the stat: ready to merge PR tested and approved waiting for merge label Mar 8, 2023
@kodiakhq kodiakhq bot merged commit f0077cf into develop Mar 8, 2023
@kodiakhq kodiakhq bot deleted the regression/oauth-client-query branch March 8, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albuquerquefabio albuquerquefabio albuquerquefabio left review comments

@ggazzo ggazzo ggazzo approved these changes

@sampaiodiego sampaiodiego Awaiting requested review from sampaiodiego

Assignees
No one assigned
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge type: regression
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@d-gubert @ggazzo @albuquerquefabio @sampaiodiego @rodrigok