Regression: Attachment auto size #28332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionisio-bot
bot
added
the
stat: ready to merge
Codecov Report
@@ Coverage Diff @@
## develop #28332 +/- ##
===========================================
+ Coverage 44.90% 44.92% +0.02%
===========================================
Files 771 771
Lines 14980 14980
Branches 2092 2092
===========================================
+ Hits 6727 6730 +3
+ Misses 7955 7953 -2
+ Partials 298 297 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ggazzo
requested changes
Mar 8, 2023
tassoevan
previously requested changes
Mar 8, 2023
apps/meteor/client/components/message/content/urlPreviews/UrlImagePreview.tsx
Show resolved
Hide resolved
dionisio-bot
bot
added
stat: ready to merge
ggazzo
force-pushed
the
regression/image-size
branch
from
7efada1
to
f6c06d0
Compare
dionisio-bot
bot
added
stat: ready to merge
ggazzo
force-pushed
the
regression/image-size
branch
from
f6c06d0
to
475619b
Compare
dionisio-bot
bot
added
stat: ready to merge
ggazzo
force-pushed
the
regression/image-size
branch
from
475619b
to
4ec041c
Compare
dionisio-bot
bot
added
stat: ready to merge
ggazzo
previously approved these changes
Mar 8, 2023
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
dionisio-bot
bot
added
stat: ready to merge
KevLehman
reviewed
Mar 9, 2023
if we want to speedup CI task and use the lint. yes it is and it mean @hugocostadev has run at least once the eslint on his machine |
ggazzo
approved these changes
Mar 9, 2023
ggazzo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Attachment Image or Image Preview size in small screens are not respecting container boundaries
Before:
NOW:
Issue(s)
Steps to test or reproduce
Further comments
TC-530