Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename API method unauthorized method to forbidden #32083

Merged
merged 20 commits into from
Dec 23, 2024
Merged

chore: rename API method unauthorized method to forbidden #32083

merged 20 commits into from
Dec 23, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Mar 27, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 200e2b5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Mar 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.27%. Comparing base (a6bb045) to head (200e2b5).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #32083       +/-   ##
============================================
+ Coverage    59.28%   75.27%   +15.99%     
============================================
  Files         2820      516     -2304     
  Lines        67932    22540    -45392     
  Branches     15102     5485     -9617     
============================================
- Hits         40275    16968    -23307     
+ Misses       24831     4911    -19920     
+ Partials      2826      661     -2165
Flag Coverage Δ
e2e ?
e2e-api ?
unit 75.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo force-pushed the chore/api-login branch 7 times, most recently from bf64161 to 325779e Compare March 27, 2024 23:12
@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 12, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-32083/
on branch gh-pages at 2024-12-23 12:51 UTC

@ggazzo ggazzo marked this pull request as ready for review November 2, 2024 16:11
@ggazzo ggazzo requested review from a team as code owners November 2, 2024 16:11
@ggazzo ggazzo added this to the 7.1.0 milestone Nov 19, 2024
@ggazzo ggazzo modified the milestones: 7.1.0, 7.2.0 Nov 28, 2024
MarcosSpessatto
MarcosSpessatto requested changes Dec 20, 2024
View reviewed changes
apps/meteor/app/api/server/api.ts
if (shouldVerifyPermissions) {
if (!this.userId) {
if (applyBreakingChanges) {
throw new Meteor.Error('error-unauthorized', 'You must be logged in to do this');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be error-forbidden here?

apps/meteor/app/api/server/api.ts Show resolved Hide resolved
@ggazzo ggazzo merged commit 53c81bb into develop Dec 23, 2024
49 checks passed
@ggazzo ggazzo deleted the chore/api-login branch December 23, 2024 13:50
gabriellsh pushed a commit that referenced this pull request Dec 31, 2024
@ggazzo @gabriellsh
chore: rename API method unauthorized method to forbidden (#32083)
d78c667
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosSpessatto MarcosSpessatto MarcosSpessatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ggazzo @MarcosSpessatto @sampaiodiego