-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Image gallery moves to older images when clicking on the right arrow button #32106
Conversation
🦋 Changeset detectedLatest commit: 2a9b750 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32106 +/- ##
========================================
Coverage 56.37% 56.38%
========================================
Files 2437 2433 -4
Lines 53770 53724 -46
Branches 11082 11075 -7
========================================
- Hits 30315 30294 -21
+ Misses 20814 20792 -22
+ Partials 2641 2638 -3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Looks like this PR is ready to merge! 🎉 |
…nto fix/image-gallery-direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I decided to keep the e2e tests serial since the beforeAll
process is heavy. It takes more time than the actual tests, so I can't see any real benefits on making the e2e tests parallel in this case
cc @gabriellsh @tiagoevanp
…nto fix/image-gallery-direction
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The direction: 'rtl'
which I had to use to fix animations' direction is causing images to take longer to load for some reason. That's due to an issue on the swiper component (which has been reported here, but it is yet to be fixed)
So I decided to work on another approach (inverting the array instead of using the direction prop) so that we can have animations working properly. Can you please let me know what you think of this new approach? @gabriellsh @MarcosSpessatto
It looks like the issue has been closed and the developers say the bug is not with the lib itself. But since you already provided a solution by reversing the array, LGTM. |
…nto fix/image-gallery-direction
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
I suggesting using more than 5 images to test so that pagination is applied.
Before:
old-image-gallery.mp4
After:
improved-image-gallery.mp4
Further comments
SUP-419