-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: LDAP sync triggers multiple cron jobs in case an invalid sync interval is provided #32285
fix!: LDAP sync triggers multiple cron jobs in case an invalid sync interval is provided #32285
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 816102f The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #32285 +/- ##
==============================================
Coverage 75.66% 75.66%
==============================================
Files 430 430
Lines 19904 19904
Branches 5079 5079
==============================================
Hits 15060 15060
Misses 4273 4273
Partials 571 571
Flags with carried forward coverage won't be shown. Click here to find out more. |
472825d
to
68fee68
Compare
The merge-base changed after approval.
ea82dad
to
7e69ab1
Compare
bc4fad7
to
b484993
Compare
b285fd4
to
39a6fe1
Compare
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
63b8a68
to
816102f
Compare
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
…nterval is provided (#32285) * fix: use settings' packageValue as a fallback to LDAP sync intervals * fix: add migration to update the packageValue of LDAP sync interval settings --------- Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
Proposed changes (including videos or screenshots)
packageValue
s as the fallback value in case the provided value is invalid;packageValue
s (from cron description to actual cron expressions, which is the type of value expected by RC since 6.3).Issue(s)
Steps to test or reproduce
Go to Settings > LDAP > Premium and set an invalid Avatar Background Sync Interval or Auto Logout Interval.
Current behavior: cron jobs are triggered successively (there is no interval between them).
Expected behavior: cron jobs intervals should follow each setting's default value instead.
Further comments
CORE-273