Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rooms.export endpoint generates an empty export when given an invalid date #32364

Merged
merged 7 commits into from
May 20, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented May 2, 2024

Proposed changes (including videos or screenshots)

  • Use oldest possible date as dateFrom when this param is not provided to the rooms.export endpoint;
  • Use current date as dateTo when this param is not provided to the rooms.export endpoint;
  • Added end-to-end tests for the export rooms as file feature.

Issue(s)

Steps to test or reproduce

Further comments

SUP-523

Cloned from #32046 (but based on develop)

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: 5390acc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/core-typings Minor
@rocket.chat/apps Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/license Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented May 2, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@matheusbsilva137 matheusbsilva137 added this to the 6.9 milestone May 2, 2024
Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 55.63%. Comparing base (6ac3607) to head (5390acc).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32364      +/-   ##
===========================================
- Coverage    55.86%   55.63%   -0.24%     
===========================================
  Files         2432     2427       -5     
  Lines        53480    53428      -52     
  Branches     10993    11005      +12     
===========================================
- Hits         29877    29724     -153     
- Misses       20966    21077     +111     
+ Partials      2637     2627      -10     
Flag Coverage Δ
e2e 55.23% <ø> (+0.03%) ⬆️
unit 72.28% <37.50%> (-0.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 marked this pull request as ready for review May 3, 2024 13:57
@matheusbsilva137 matheusbsilva137 requested review from a team as code owners May 3, 2024 13:57
@KevLehman KevLehman added the stat: QA assured Means it has been tested and approved by a company insider label May 17, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 17, 2024
@kodiakhq kodiakhq bot merged commit f83bd56 into develop May 20, 2024
45 of 46 checks passed
@kodiakhq kodiakhq bot deleted the fix/rooms-export-invalid-date branch May 20, 2024 21:39
gabriellsh added a commit that referenced this pull request May 28, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat: (36 commits)
  refactor: IntegrationHistory out of DB Watcher (#32502)
  fix: Message update being broadcasted without updated values (#32472)
  test: make api teams test fully independent (#31756)
  test: Fix test name (#32490)
  fix: streams being called with no logged user (#32489)
  feat: Un-encrypted messages not allowed in E2EE rooms (#32040)
  feat(UiKit): Users select (#31455)
  fix: Re-login same browser tab issues (#32479)
  chore: move all webclient code out of the COSS folders (#32273)
  chore(deps): bump thehanimo/pr-title-checker from 1.3.7 to 1.4.1 (#30619)
  fix: Don't show join default channels option for edit user form  (#31750)
  fix: CAS user merge not working (#32444)
  fix: Overriding Retention Policy not working (#32454)
  fix: `rooms.export` endpoint generates an empty export when given an invalid date (#32364)
  fix: "Allow Password Change for OAuth Users" setting is not honored in the "Forgot Password" flow (#32398)
  fix: Bypass trash when removing OTR system messages and read receipts (#32269)
  fix: Monitors dissapearing from Unit upon edit (#32393)
  fix: Link image preview not opening in gallery (#32391)
  feat: Allow visitors & integrations to access downloaded files after a room has closed (#32439)
  regression: Users tab misaligned (#32451)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants