Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Incorrect retention policy banner's display rule for teams #32483

Merged
merged 2 commits into from
May 24, 2024

Conversation

dougfabris
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented May 23, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@dougfabris dougfabris force-pushed the reg/retention-teams branch from e8f84b7 to 4adf218 Compare May 23, 2024 21:02
Copy link

changeset-bot bot commented May 23, 2024

⚠️ No Changeset found

Latest commit: ea71de3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.95%. Comparing base (e3c2fb6) to head (ea71de3).

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           release-6.9.0   #32483      +/-   ##
=================================================
- Coverage          55.98%   55.95%   -0.03%     
=================================================
  Files               2431     2431              
  Lines              53557    53553       -4     
  Branches           11029    11029              
=================================================
- Hits               29985    29967      -18     
- Misses             20939    20953      +14     
  Partials            2633     2633              
Flag Coverage Δ
e2e 55.39% <100.00%> (-0.06%) ⬇️
unit 72.28% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.9 milestone May 23, 2024
@dougfabris dougfabris marked this pull request as ready for review May 24, 2024 14:48
@dougfabris dougfabris requested a review from a team as a code owner May 24, 2024 14:48
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label May 24, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label May 24, 2024
@kodiakhq kodiakhq bot merged commit 61bf555 into release-6.9.0 May 24, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the reg/retention-teams branch May 24, 2024 18:01
gabriellsh added a commit that referenced this pull request Jun 3, 2024
…retention

* 'develop' of github.com:RocketChat/Rocket.Chat:
  Release 6.9.0
  Release 6.9.0-rc.2
  fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500)
  fix: User status when setting "Use REST instead of websocket for Meteor calls" is disabled (#32500)
  regression: Hide prune section based on permission (#32531)
  fix: Users in role table not rendering the empty state properly (#32412)
  refactor: EmailInbox out of DB Watcher (#32501)
  ci: increase issue allowed stale time (#32523)
  regression: Remove impossible sorting from users table "registration status" column (#32506)
  feat: Add contentDisposition option to file storages (#31974)
  i18n: Rocket.Chat language update from LingoHub 🤖 on 2024-05-28Z (#32508)
  Release 6.9.0-rc.1
  fix: Re-login same browser tab issues (#32479)
  regression: Replace read receipt single icon (#32486)
  regression: Incorrect retention policy banner's display rule for teams (#32483)
  chore: Publish npm packages again (#32463)
  ci: publish missing Omnichannel services to DockerHub (#32462)
  Release 6.9.0-rc.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants