Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codeBlock styles in light mode #32499

Merged
merged 7 commits into from
Jun 3, 2024
Merged

fix: codeBlock styles in light mode #32499

merged 7 commits into from
Jun 3, 2024

Conversation

juliajforesti
Copy link
Contributor

@juliajforesti juliajforesti commented May 24, 2024

SUP-583

Proposed changes (including videos or screenshots)

Issue(s)

codeBlock styles for dark mode were being applied for light mode too

Steps to test or reproduce

Further comments

SUP-583

Copy link
Contributor

dionisio-bot bot commented May 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 24, 2024

🦋 Changeset detected

Latest commit: 63d585e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.37%. Comparing base (bbb92fc) to head (63d585e).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32499      +/-   ##
===========================================
+ Coverage    56.36%   56.37%   +0.01%     
===========================================
  Files         2433     2435       +2     
  Lines        53702    53710       +8     
  Branches     11061    11062       +1     
===========================================
+ Hits         30267    30277      +10     
+ Misses       20787    20783       -4     
- Partials      2648     2650       +2     
Flag Coverage Δ
e2e 56.08% <80.00%> (-0.01%) ⬇️
unit 72.21% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@juliajforesti juliajforesti changed the title fix: codeBlock styles in light mode fix: codeBlock styles May 24, 2024
@juliajforesti juliajforesti changed the title fix: codeBlock styles fix: codeBlock styles in light mode May 24, 2024
@juliajforesti juliajforesti marked this pull request as ready for review May 24, 2024 22:04
@juliajforesti juliajforesti requested review from a team as code owners May 24, 2024 22:04
@scuciatto scuciatto added this to the 6.10 milestone May 29, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some UI tests to validate this? I don't know maybe to ensure a class to be applied?

@juliajforesti juliajforesti requested review from a team as code owners June 3, 2024 13:34
@juliajforesti juliajforesti requested review from MarcosSpessatto and removed request for a team June 3, 2024 15:21
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jun 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 3, 2024
@kodiakhq kodiakhq bot merged commit f659c6e into develop Jun 3, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the fix/codeBlock-styles branch June 3, 2024 20:09
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants