-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: codeBlock
styles in light mode
#32499
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 63d585e The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32499 +/- ##
===========================================
+ Coverage 56.36% 56.37% +0.01%
===========================================
Files 2433 2435 +2
Lines 53702 53710 +8
Branches 11061 11062 +1
===========================================
+ Hits 30267 30277 +10
+ Misses 20787 20783 -4
- Partials 2648 2650 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
codeBlock
styles in light modecodeBlock
styles
codeBlock
stylescodeBlock
styles in light mode
6dd0bda
to
ca6ed8d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some UI tests to validate this? I don't know maybe to ensure a class to be applied?
69db62a
to
63d585e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
SUP-583
Proposed changes (including videos or screenshots)
Issue(s)
codeBlock styles for dark mode were being applied for light mode too
Steps to test or reproduce
Further comments
SUP-583