Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate banners.getNew endpoint #32525

Merged
merged 5 commits into from
Jun 3, 2024

Conversation

matheusbsilva137
Copy link
Member

@matheusbsilva137 matheusbsilva137 commented May 29, 2024

Proposed changes (including videos or screenshots)

  • Deprecate banners.getNew endpoint (which wasn't properly deprecated even though we had a comment in the code)

Issue(s)

Steps to test or reproduce

Further comments

CORE-472

Requested in #32509

Copy link
Contributor

dionisio-bot bot commented May 29, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.10.0, but it targets 6.9.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented May 29, 2024

⚠️ No Changeset found

Latest commit: a64b8c0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.36%. Comparing base (bbb92fc) to head (a64b8c0).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32525   +/-   ##
========================================
  Coverage    56.36%   56.36%           
========================================
  Files         2433     2434    +1     
  Lines        53702    53679   -23     
  Branches     11061    11056    -5     
========================================
- Hits         30267    30256   -11     
+ Misses       20787    20775   -12     
  Partials      2648     2648           
Flag Coverage Δ
e2e 56.07% <ø> (-0.02%) ⬇️
unit 72.20% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@matheusbsilva137 matheusbsilva137 added this to the 6.10 milestone May 29, 2024
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jun 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 3, 2024
@kodiakhq kodiakhq bot merged commit 3da6e14 into develop Jun 3, 2024
46 of 47 checks passed
@kodiakhq kodiakhq bot deleted the chore/deprecate-banners-getNew branch June 3, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
squad: core stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants