-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Deprecate banners.getNew
endpoint
#32525
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32525 +/- ##
========================================
Coverage 56.36% 56.36%
========================================
Files 2433 2434 +1
Lines 53702 53679 -23
Branches 11061 11056 -5
========================================
- Hits 30267 30256 -11
+ Misses 20787 20775 -12
Partials 2648 2648
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
banners.getNew
endpoint (which wasn't properly deprecated even though we had a comment in the code)Issue(s)
Steps to test or reproduce
Further comments
CORE-472
Requested in #32509