-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Marketplace): Wrong modal if app already purchased #32563
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: f8d5fbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32563 +/- ##
========================================
Coverage 56.51% 56.51%
========================================
Files 2484 2484
Lines 54777 54777
Branches 11318 11318
========================================
+ Hits 30957 30958 +1
+ Misses 21172 21170 -2
- Partials 2648 2649 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add an e2e test to confirm the flow is correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since currently there's no way to test the UI on the marketplace without register the server we leave the tests for the foreseeable future.
Fixed Issue that caused a purchase modal to appear even if the app was already acquired in some cases.
CORE-427