Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Marketplace): Wrong modal if app already purchased #32563

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

MartinSchoeler
Copy link
Contributor

@MartinSchoeler MartinSchoeler commented Jun 5, 2024

Fixed Issue that caused a purchase modal to appear even if the app was already acquired in some cases.

CORE-427

Copy link
Contributor

dionisio-bot bot commented Jun 5, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: f8d5fbb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.51%. Comparing base (2ad192b) to head (f8d5fbb).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32563   +/-   ##
========================================
  Coverage    56.51%   56.51%           
========================================
  Files         2484     2484           
  Lines        54777    54777           
  Branches     11318    11318           
========================================
+ Hits         30957    30958    +1     
+ Misses       21172    21170    -2     
- Partials      2648     2649    +1     
Flag Coverage Δ
unit 71.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler added this to the 6.10 milestone Jun 5, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review June 5, 2024 19:08
@MartinSchoeler MartinSchoeler requested a review from a team as a code owner June 5, 2024 19:08
Copy link
Contributor

@csuadev csuadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add an e2e test to confirm the flow is correct?

Copy link
Contributor

@csuadev csuadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since currently there's no way to test the UI on the marketplace without register the server we leave the tests for the foreseeable future.

@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jun 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
@ggazzo ggazzo merged commit 2f7597e into develop Jun 21, 2024
19 checks passed
@ggazzo ggazzo deleted the marketplace-invalidate-query branch June 21, 2024 02:30
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants