Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Omnichannel): Contact Center sort by date #32566

Merged
merged 12 commits into from
Jun 19, 2024

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Jun 6, 2024

Proposed changes (including videos or screenshots)

Fix the sorting by last chat in Contact Center table.

Issue(s)

Steps to test or reproduce

Further comments

SUP-578

Copy link
Contributor

dionisio-bot bot commented Jun 6, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: 1ebc017

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.06%. Comparing base (02dd875) to head (1ebc017).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32566      +/-   ##
===========================================
- Coverage    56.52%   55.06%   -1.47%     
===========================================
  Files         2484     2397      -87     
  Lines        54691    53207    -1484     
  Branches     11287    10946     -341     
===========================================
- Hits         30916    29298    -1618     
- Misses       21126    21319     +193     
+ Partials      2649     2590      -59     
Flag Coverage Δ
e2e 53.35% <ø> (-2.81%) ⬇️
unit 72.17% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp changed the title Fix(Omnichannel): Contact Center sort by date fix(Omnichannel): Contact Center sort by date Jun 7, 2024
@tiagoevanp tiagoevanp marked this pull request as ready for review June 10, 2024 20:12
@tiagoevanp tiagoevanp requested review from a team as code owners June 10, 2024 20:12
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a description and a changeset to the PR?

Also, it would be awesome to have a UI test covering the solution, do you think it's possible to add it?

@tiagoevanp
Copy link
Contributor Author

About the UI test: It's very expensive to create another test than the API integration one and there is no necessity of testing in the UI the same thing was tested from integration (if the API result is right). The fix here is not in the UI, but the API not receiving the right query string parameters.

apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
apps/meteor/tests/data/livechat/rooms.ts Outdated Show resolved Hide resolved
@scuciatto scuciatto added the stat: QA assured Means it has been tested and approved by a company insider label Jun 19, 2024
@dougfabris dougfabris added this to the 6.10 milestone Jun 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 19, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kodiakhq kodiakhq bot merged commit 70e3968 into develop Jun 19, 2024
36 of 45 checks passed
@kodiakhq kodiakhq bot deleted the fix/omnichannel-contact-sort-by-date branch June 19, 2024 14:40
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants