Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve Retention Policy Warning and Callout messages #32579

Merged
merged 11 commits into from
Jun 21, 2024

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jun 10, 2024

Proposed changes (including videos or screenshots)

Added cron run time to warning message.

image image

Issue(s)

CORE-303

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 10, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 10, 2024

🦋 Changeset detected

Latest commit: 49092af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 98.30508% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.58%. Comparing base (6274c43) to head (49092af).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32579      +/-   ##
===========================================
+ Coverage    56.54%   56.58%   +0.04%     
===========================================
  Files         2490     2492       +2     
  Lines        55028    55080      +52     
  Branches     11385    11393       +8     
===========================================
+ Hits         31114    31168      +54     
+ Misses       21231    21229       -2     
  Partials      2683     2683              
Flag Coverage Δ
e2e 56.20% <71.42%> (+<0.01%) ⬆️
unit 71.87% <98.07%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris added this to the 6.10 milestone Jun 19, 2024
Base automatically changed from imp/retention to develop June 21, 2024 02:36
@gabriellsh gabriellsh marked this pull request as ready for review June 21, 2024 14:32
@gabriellsh gabriellsh requested a review from a team as a code owner June 21, 2024 14:32
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jun 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2024
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad to approve another WOW work!

@ggazzo ggazzo merged commit d3c493b into develop Jun 21, 2024
47 of 48 checks passed
@ggazzo ggazzo deleted the imp/retentionMessage branch June 21, 2024 20:58
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants