-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Modal backdrop overlapping Select
options
#32640
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 984faff The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32640 +/- ##
===========================================
- Coverage 56.56% 56.53% -0.03%
===========================================
Files 2484 2484
Lines 54755 54755
Branches 11308 11308
===========================================
- Hits 30971 30955 -16
- Misses 21107 21120 +13
- Partials 2677 2680 +3
Flags with carried forward coverage won't be shown. Click here to find out more. |
Proposed changes (including videos or screenshots)
Introduced here: #32067
In order to solve an issue where the
UserCard
was overlapping the Modal as shown in the PR above we changed thez-index
ofModalBackdrop
and it caused theModalBackdrop
overlapping theSelect
options.So to solve it, we come back with the old
z-index
value and added a callbackAction to close theUserCard
as soon as the action is triggered.before
after
Issue(s)
Steps to test or reproduce
Further comments
CORE-522