Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal backdrop overlapping Select options #32640

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Jun 19, 2024

Proposed changes (including videos or screenshots)

Introduced here: #32067

In order to solve an issue where the UserCard was overlapping the Modal as shown in the PR above we changed the z-index of ModalBackdrop and it caused the ModalBackdrop overlapping the Select options.

So to solve it, we come back with the old z-index value and added a callbackAction to close the UserCard as soon as the action is triggered.

before

after

Issue(s)

Steps to test or reproduce

Further comments

CORE-522

Copy link
Contributor

dionisio-bot bot commented Jun 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: 984faff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dougfabris dougfabris added this to the 6.10 milestone Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 56.53%. Comparing base (1428778) to head (984faff).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32640      +/-   ##
===========================================
- Coverage    56.56%   56.53%   -0.03%     
===========================================
  Files         2484     2484              
  Lines        54755    54755              
  Branches     11308    11308              
===========================================
- Hits         30971    30955      -16     
- Misses       21107    21120      +13     
- Partials      2677     2680       +3     
Flag Coverage Δ
e2e 56.18% <83.33%> (-0.06%) ⬇️
unit 72.15% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

tassoevan
tassoevan previously approved these changes Jun 19, 2024
@dougfabris dougfabris marked this pull request as ready for review June 20, 2024 19:03
@dougfabris dougfabris requested a review from a team as a code owner June 20, 2024 19:03
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 21, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 21, 2024
@ggazzo ggazzo merged commit 9c925a3 into develop Jun 21, 2024
50 checks passed
@ggazzo ggazzo deleted the fix/selectOptionsDisplay branch June 21, 2024 03:05
This was referenced Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants