Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Fix encrypted file upload ignoring enabling setting #32670

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

rodrigok
Copy link
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@rodrigok rodrigok added this to the 6.10 milestone Jun 25, 2024
@rodrigok rodrigok requested a review from a team as a code owner June 25, 2024 17:41
Copy link
Contributor

dionisio-bot bot commented Jun 25, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 25, 2024

⚠️ No Changeset found

Latest commit: d34b831

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.73%. Comparing base (326bd01) to head (d34b831).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           release-6.10.0   #32670   +/-   ##
===============================================
  Coverage           56.73%   56.73%           
===============================================
  Files                2496     2496           
  Lines               55360    55360           
  Branches            11455    11455           
===============================================
  Hits                31406    31406           
+ Misses              21282    21252   -30     
- Partials             2672     2702   +30     
Flag Coverage Δ
e2e 56.47% <100.00%> (ø)
unit 71.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jun 26, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jun 26, 2024
@ggazzo ggazzo merged commit a173e33 into release-6.10.0 Jun 26, 2024
50 checks passed
@ggazzo ggazzo deleted the fix/regression-file-upload-e2ee branch June 26, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants