Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: Fix new user panel memory exceeded error #32696

Merged
merged 11 commits into from
Jul 3, 2024

Conversation

rique223
Copy link
Contributor

@rique223 rique223 commented Jun 28, 2024

Proposed changes (including videos or screenshots)

Added allowDiskUse option to the users panel query which should solve situations in which the number of users of a workspace is so big that it exceeds the 100MB MongoDb memory threshold;

Jira task: CONN-277

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jun 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 74c359d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.52%. Comparing base (957cc80) to head (76bff9a).
Report is 1 commits behind head on release-6.10.0.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-6.10.0   #32696      +/-   ##
==================================================
+ Coverage           56.51%   56.52%   +0.01%     
==================================================
  Files                2495     2494       -1     
  Lines               55448    55434      -14     
  Branches            11443    11443              
==================================================
  Hits                31336    31336              
+ Misses              21457    21410      -47     
- Partials             2655     2688      +33     
Flag Coverage Δ
e2e 56.42% <ø> (+0.02%) ⬆️
unit 71.45% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rique223 rique223 added this to the 6.10 milestone Jun 28, 2024
ggazzo
ggazzo previously requested changes Jul 2, 2024
.changeset/dull-knives-complain.md Show resolved Hide resolved
@tassoevan tassoevan force-pushed the regression/user-panel-memory branch from edbf5e9 to ab7e63d Compare July 2, 2024 14:21
@rique223 rique223 marked this pull request as ready for review July 3, 2024 12:54
@rique223 rique223 requested a review from ggazzo July 3, 2024 16:33
@tassoevan tassoevan dismissed ggazzo’s stale review July 3, 2024 17:59

all issues were addressed

@tassoevan tassoevan removed the request for review from ggazzo July 3, 2024 18:03
@tassoevan tassoevan added the stat: QA assured Means it has been tested and approved by a company insider label Jul 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 3, 2024
@kodiakhq kodiakhq bot merged commit 83d9270 into release-6.10.0 Jul 3, 2024
12 of 13 checks passed
@kodiakhq kodiakhq bot deleted the regression/user-panel-memory branch July 3, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants