Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps): bridge method for removing users of a room #32706

Merged
merged 9 commits into from
Jul 12, 2024
Merged

Conversation

gabriellsh
Copy link
Member

@gabriellsh gabriellsh commented Jul 1, 2024

Proposed changes (including videos or screenshots)

Implemented bridge method for RocketChat/Rocket.Chat.Apps-engine#776

Issue(s)

CORE-498

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jul 1, 2024

🦋 Changeset detected

Latest commit: 05b1159

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 1, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.66%. Comparing base (0a46a11) to head (05b1159).
Report is 2 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32706      +/-   ##
===========================================
- Coverage    56.72%   56.66%   -0.06%     
===========================================
  Files         2504     2504              
  Lines        55518    55518              
  Branches     11440    11440              
===========================================
- Hits         31490    31459      -31     
- Misses       21341    21370      +29     
- Partials      2687     2689       +2     
Flag Coverage Δ
e2e 56.48% <ø> (-0.11%) ⬇️
unit 72.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@d-gubert d-gubert changed the title feat: Apps-engine bridge method for removing users of a room feat(apps): bridge method for removing users of a room Jul 8, 2024
@d-gubert d-gubert marked this pull request as ready for review July 10, 2024 22:43
@d-gubert d-gubert requested review from a team as code owners July 10, 2024 22:43
d-gubert
d-gubert previously approved these changes Jul 10, 2024
…/removeUsers

* 'develop' of github.com:RocketChat/Rocket.Chat:
  refactor(omnichannel): replace create and find by findAndUpdate (#32773)
  chore: Bump apps engine 1.44-alpha (#32774)
  refactor(client): Remove usage of `React.FC` type (#32760)
  refactor(Livechat): `Livechat/Message/markdown.js` -> TS (#32295)
  refactor(omnichannel): spare few Room.find on requestRoom method (#32363)
  refactor:  `dispatchInquiryPosition` being called multiple times (#32767)
  fix: SAML "Overwrite user fullname" setting is not being honored (#32628)
  fix(Omnichannel): Use Correct components on ChatInfo (#32592)
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 12, 2024
@ggazzo ggazzo merged commit 16a9c86 into develop Jul 12, 2024
50 checks passed
@ggazzo ggazzo added this to the 6.11 milestone Jul 12, 2024
@ggazzo ggazzo deleted the apps/removeUsers branch July 12, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants