-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sendFCM
function not using @rocket.chat/server-fetch
#32739
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 2304a31 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sendFCM
function not using @rocket.chat/serverFetch
sendFCM
function not using @rocket.chat/server-fetch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32739 +/- ##
===========================================
+ Coverage 50.82% 56.84% +6.02%
===========================================
Files 1933 2498 +565
Lines 46542 55346 +8804
Branches 9419 11416 +1997
===========================================
+ Hits 23654 31461 +7807
- Misses 20755 21171 +416
- Partials 2133 2714 +581
Flags with carried forward coverage won't be shown. Click here to find out more. |
Use legacy notification provider setting is disabled in Workspace > Settings > Push, push notifications stop going to Android devices. PR Should fix this situation for using a proxy for it
Proposed changes (including videos or screenshots)
Issue(s)
https://rocketchat.atlassian.net/browse/SUP-616
Steps to test or reproduce
Further comments