fix: option to start a discussion on an existing message is not showing up

[pierre-lehnen-rc]

The condition to show the "Start a Discussion" option on the message Actions list was accidentally changed as a side effect of an older PR.

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

PR #23971 changed a reference to the global isNaN with Number.isNaN. The two functions are not interchangeable, despite having the same name.
The global isNaN will check if something is not a number, while Number.isNaN checks if the specified value is specifically NaN.
In the condition for the discussion action, an undefined dcount would cause Number.isNaN to return false and rocket.chat would then hide the option thinking that it is already a discussion.

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

🦋 Changeset detected

Latest commit: b500826

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/api-client	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.60%. Comparing base (580c1ed) to head (b500826).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32765      +/-   ##
===========================================
+ Coverage    55.53%   55.60%   +0.07%     
===========================================
  Files         2633     2637       +4     
  Lines        57259    57308      +49     
  Branches     11861    11868       +7     
===========================================
+ Hits         31796    31865      +69     
+ Misses       22773    22752      -21     
- Partials      2690     2691       +1     

Flag	Coverage Δ
e2e	54.32% <0.00%> (+0.17%)	⬆️
unit	72.33% <ø> (-0.09%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.