-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Sidebar scrolling misclick issue on iOS #32769
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 52b02c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32769 +/- ##
===========================================
- Coverage 55.50% 55.44% -0.07%
===========================================
Files 2637 2635 -2
Lines 57289 57270 -19
Branches 11859 11855 -4
===========================================
- Hits 31797 31752 -45
- Misses 22801 22828 +27
+ Partials 2691 2690 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than the comment left.
Putting this as draft since the issue seems more complex than initially estimated |
3df4802
to
c46866c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix missing changeset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
An outdated polyfill was causing misclick issues when scrolling the channels sidebar
Issue(s)
Steps to test or reproduce
Further comments
SUP-582