Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Omnichannel): Attachments in Email Transcripts #32777

Merged
merged 12 commits into from
Jul 19, 2024

Conversation

yash-rajpal
Copy link
Member

@yash-rajpal yash-rajpal commented Jul 12, 2024

Proposed changes (including videos or screenshots)

File attachments were not being handled in email transcripts, so implemented file attachments in email transcripts and invalid attachment message for attachments other than images.

image

Issue(s)

Steps to test or reproduce

Further comments

CORE-554

Copy link
Contributor

dionisio-bot bot commented Jul 12, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: 620a3b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.57%. Comparing base (47819cd) to head (620a3b7).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32777      +/-   ##
===========================================
+ Coverage    55.51%   55.57%   +0.05%     
===========================================
  Files         2634     2634              
  Lines        57248    57248              
  Branches     11853    11853              
===========================================
+ Hits         31784    31813      +29     
+ Misses       22769    22744      -25     
+ Partials      2695     2691       -4     
Flag Coverage Δ
e2e 54.32% <ø> (+0.08%) ⬆️
unit 72.09% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@yash-rajpal yash-rajpal marked this pull request as ready for review July 12, 2024 21:05
@yash-rajpal yash-rajpal requested a review from a team as a code owner July 12, 2024 21:05
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any way of adding some tests here?

.changeset/weak-taxis-design.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tiagoevanp tiagoevanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of PR is confusing, can you add a similar message from the changeset and show in the images who is before/after?

yash-rajpal and others added 2 commits July 15, 2024 23:40
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
KevLehman
KevLehman previously approved these changes Jul 16, 2024
@yash-rajpal yash-rajpal added this to the 6.11 milestone Jul 18, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2024
@yash-rajpal yash-rajpal dismissed MarcosSpessatto’s stale review July 19, 2024 14:30

Discussed on DM, will implement tests for whole class separately

@kodiakhq kodiakhq bot merged commit d3a6299 into develop Jul 19, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the feat/oc-attachment-email-transcripts branch July 19, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants