Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to change subject for email transcript #32792

Merged
merged 16 commits into from
Jul 24, 2024

Conversation

KevLehman
Copy link
Contributor

@KevLehman KevLehman commented Jul 15, 2024

Proposed changes (including videos or screenshots)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-495

Steps to test or reproduce

Further comments

Allows admins to customize the Subject field of Omnichannel email transcripts via Custom email subject for transcript setting.

Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: e7fa992

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/i18n Minor
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 15, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 42 lines in your changes missing coverage. Please review.

Project coverage is 55.45%. Comparing base (05db8aa) to head (e7fa992).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32792      +/-   ##
===========================================
- Coverage    55.50%   55.45%   -0.05%     
===========================================
  Files         2637     2638       +1     
  Lines        57289    57378      +89     
  Branches     11859    11881      +22     
===========================================
+ Hits         31797    31819      +22     
- Misses       22801    22861      +60     
- Partials      2691     2698       +7     
Flag Coverage Δ
e2e 54.01% <50.00%> (-0.09%) ⬇️
unit 72.22% <53.40%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@KevLehman KevLehman marked this pull request as ready for review July 16, 2024 16:14
@KevLehman KevLehman requested review from a team as code owners July 16, 2024 16:14
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2024
MartinSchoeler
MartinSchoeler previously approved these changes Jul 18, 2024
@casalsgh casalsgh added this to the 6.11 milestone Jul 22, 2024
MartinSchoeler
MartinSchoeler previously approved these changes Jul 22, 2024
@KevLehman KevLehman added the stat: ready to merge PR tested and approved waiting for merge label Jul 22, 2024
@kodiakhq kodiakhq bot merged commit b4bbcbf into develop Jul 24, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/change-subject-on-transcript branch July 24, 2024 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants