-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Client crashing on firefox private window #32807
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c3ee33f The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32807 +/- ##
===========================================
- Coverage 55.57% 55.52% -0.05%
===========================================
Files 2634 2634
Lines 57248 57252 +4
Branches 11853 11857 +4
===========================================
- Hits 31816 31791 -25
- Misses 22748 22766 +18
- Partials 2684 2695 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned via chat, the channel files tab is crashing the browser too, we need to check if there any other places that tries to access the problematic property
Co-authored-by: Kevin Aleman <kaleman960@gmail.com>
/patch |
after that just run |
/patch |
Pull request #32946 added to Project: "Patch 6.10.2" |
/patch |
after that just run |
/patch |
Pull request #32950 added to Project: "Patch 6.10.2" |
Proposed changes (including videos or screenshots)
The web client was crashing on firefox's private window, due to unavailability of service workers on private window.
This PR handles this case, the limitation being that users cannot view or download the encrypted attachments on firefox private window.
Issue(s)
Closes #32758
Closes #32826
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/CORE-559