Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bad word filtering not working #32810

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Jul 17, 2024

Proposed changes (including videos or screenshots)

Fixes bad word filtering not working issue. If we look into the DB record, we'll see the message has been edited, but the UI still shows the word. The issue was identified to be due to displaying the value in the md property, and not the msg property, and the md is not edited to filter the bad words.
This occurs due to bad word filter service running after the markdown parser.

Screen.Recording.2024-07-17.at.5.31.31.PM.mov

Issue(s)

Steps to test or reproduce

Further comments

SUP-624

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Copy link

changeset-bot bot commented Jul 17, 2024

🦋 Changeset detected

Latest commit: 4cf9f4d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 17, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.54%. Comparing base (3cfd6dd) to head (4cf9f4d).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32810      +/-   ##
===========================================
- Coverage    55.54%   55.54%   -0.01%     
===========================================
  Files         2634     2633       -1     
  Lines        57215    57184      -31     
  Branches     11849    11843       -6     
===========================================
- Hits         31782    31762      -20     
+ Misses       22742    22737       -5     
+ Partials      2691     2685       -6     
Flag Coverage Δ
e2e 54.28% <ø> (-0.04%) ⬇️
unit 72.17% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin marked this pull request as ready for review July 17, 2024 13:22
@abhinavkrin abhinavkrin requested review from a team as code owners July 17, 2024 13:22
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some api tests?

Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin added this to the 6.11 milestone Jul 18, 2024
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Jul 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 18, 2024
@kodiakhq kodiakhq bot merged commit 2febca2 into develop Jul 18, 2024
49 checks passed
@kodiakhq kodiakhq bot deleted the fix/bad-word-filtering-not-working branch July 18, 2024 19:57
debdutdeb pushed a commit that referenced this pull request Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants