feat: Allow admins to decide if email transcript should be sent always #32820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 473bc6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32820 +/- ##
===========================================
- Coverage 55.48% 55.47% -0.02%
===========================================
Files 2636 2637 +1
Lines 57365 57391 +26
Branches 11881 11892 +11
===========================================
+ Hits 31831 31836 +5
- Misses 22837 22854 +17
- Partials 2697 2701 +4
Flags with carried forward coverage won't be shown. Click here to find out more. |
MarcosSpessatto
requested changes
Jul 18, 2024
apps/meteor/tests/unit/app/livechat/server/lib/parseTranscriptRequest.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat>
MartinSchoeler
previously approved these changes
Jul 22, 2024
KevLehman
commented
Jul 22, 2024
MarcosSpessatto
previously approved these changes
Jul 23, 2024
MartinSchoeler
requested changes
Jul 23, 2024
apps/meteor/client/views/account/omnichannel/PreferencesConversationTranscript.tsx
Outdated
Show resolved
Hide resolved
renatobecker
added
the
stat: QA assured
dionisio-bot
bot
added
the
stat: ready to merge
MartinSchoeler
previously approved these changes
Jul 23, 2024
matheusbsilva137
previously approved these changes
Jul 23, 2024
kodiakhq
bot
removed
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
KevLehman
dismissed stale reviews from matheusbsilva137 and MartinSchoeler
via
a1089ee
KevLehman
added
the
stat: ready to merge
|
This PR currently has a merge conflict. Please resolve this and then re-add the |
kodiakhq
bot
removed
the
stat: ready to merge
Merged
debdutdeb
pushed a commit
that referenced
this pull request
Jul 31, 2024
#32820) Co-authored-by: Marcos Spessatto Defendi <marcos.defendi@rocket.chat> Co-authored-by: Guilherme Gazzo <guilhermegazzo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added a new setting
Livechat_transcript_send_alwaysthat allows admins to decide if email transcript should be sent all the times when a conversation is closed. This setting bypasses agent's preferences. For this setting to work,Livechat_enable_transcriptshould be off, meaning that visitors will no longer receive the option to decide if they want a transcript or not.Note: When this setting is true, agent's preferences regarding email transcript will be disabled and ignored. The description of the preference was accommodated to let users know about this change.
Issue(s)
https://rocketchat.atlassian.net/browse/CORE-496
Steps to test or reproduce
Further comments