Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add contact identification settings #32893

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

Gustrb
Copy link
Contributor

@Gustrb Gustrb commented Jul 24, 2024

Proposed changes (including videos or screenshots)

Adding the new settings that are going to be used to configure how we are going to validate contacts using the new app.
Those settings will later be hidden, but we need them beforehand to be able to code the Omnichannel settings tab about Contact Info :P

Issue(s)

Steps to test or reproduce

Further comments

SCI2-8

Copy link
Contributor

dionisio-bot bot commented Jul 24, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: 9d418a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 34 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n Patch
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/ui-client Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Gustrb Gustrb changed the title chore: Add contact identification settings feat: Add contact identification settings Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.63%. Comparing base (9397779) to head (9d418a2).

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           feat/single-contact-id   #32893      +/-   ##
==========================================================
+ Coverage                   55.58%   55.63%   +0.05%     
==========================================================
  Files                        2646     2643       -3     
  Lines                       57430    57279     -151     
  Branches                    11917    11880      -37     
==========================================================
- Hits                        31920    31868      -52     
+ Misses                      22784    22695      -89     
+ Partials                     2726     2716      -10     
Flag Coverage Δ
e2e 54.27% <ø> (+0.18%) ⬆️
unit 72.09% <ø> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@Gustrb Gustrb marked this pull request as ready for review July 24, 2024 19:55
@Gustrb Gustrb requested a review from a team as a code owner July 24, 2024 19:55
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove this property since its already being added under "Omnichannel" group

apps/meteor/ee/app/livechat-enterprise/server/settings.ts Outdated Show resolved Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/settings.ts Outdated Show resolved Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/settings.ts Outdated Show resolved Hide resolved
apps/meteor/ee/app/livechat-enterprise/server/settings.ts Outdated Show resolved Hide resolved
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
Copy link
Member

@dougfabris dougfabris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gustrb Gustrb requested a review from KevLehman July 25, 2024 14:32
@dougfabris dougfabris merged commit 81c9ea0 into feat/single-contact-id Jul 25, 2024
49 checks passed
@dougfabris dougfabris deleted the feat/add-privacy-settings branch July 25, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants