-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add contact identification settings #32893
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: 9d418a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 34 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #32893 +/- ##
==========================================================
+ Coverage 55.58% 55.63% +0.05%
==========================================================
Files 2646 2643 -3
Lines 57430 57279 -151
Branches 11917 11880 -37
==========================================================
- Hits 31920 31868 -52
+ Misses 22784 22695 -89
+ Partials 2726 2716 -10
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can remove this property since its already being added under "Omnichannel" group
Co-authored-by: Douglas Fabris <devfabris@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Proposed changes (including videos or screenshots)
Adding the new settings that are going to be used to configure how we are going to validate contacts using the new app.
Those settings will later be hidden, but we need them beforehand to be able to code the Omnichannel settings tab about Contact Info :P
Issue(s)
Steps to test or reproduce
Further comments
SCI2-8