-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: custom-emoji functions out of meteor methods #32925
Conversation
|
Looks like this PR is ready to merge! 🎉 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #32925 +/- ##
========================================
Coverage 54.98% 54.98%
========================================
Files 2596 2596
Lines 55966 55966
Branches 11585 11585
========================================
Hits 30771 30771
Misses 22552 22552
Partials 2643 2643
Flags with carried forward coverage won't be shown. Click here to find out more. |
f4758aa
to
e5f224b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some API tests to cover this?
Also, can we rewrite the PR title to be clearer?
We already have tests for the emoji-custom endpoint. I will be adding tests along with my next pr for the fix. |
fb311c4
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
ff62710
to
3192f24
Compare
Proposed changes (including videos or screenshots)
This pr refactors insertOrUpdateEmoji uploadEmojiCustom methods by extracting the logic to separate function and using theme in emoji-custom endpoint instead of the methods.
Refactoring the code will help moving forward with the fix for the update emoji issues.
Closes #26980
SUP-622
The goal is to break the PR #32768 into smaller prs.
Issue(s)
Steps to test or reproduce
Further comments