Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: custom-emoji functions out of meteor methods #32925

Merged
merged 3 commits into from
Aug 8, 2024

Conversation

abhinavkrin
Copy link
Member

@abhinavkrin abhinavkrin commented Jul 29, 2024

Proposed changes (including videos or screenshots)

This pr refactors insertOrUpdateEmoji uploadEmojiCustom methods by extracting the logic to separate function and using theme in emoji-custom endpoint instead of the methods.

Refactoring the code will help moving forward with the fix for the update emoji issues.
Closes #26980
SUP-622
The goal is to break the PR #32768 into smaller prs.

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Jul 29, 2024

⚠️ No Changeset found

Latest commit: 3a5eba5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Jul 29, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.98%. Comparing base (5388eef) to head (3a5eba5).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32925   +/-   ##
========================================
  Coverage    54.98%   54.98%           
========================================
  Files         2596     2596           
  Lines        55966    55966           
  Branches     11585    11585           
========================================
  Hits         30771    30771           
  Misses       22552    22552           
  Partials      2643     2643           
Flag Coverage Δ
unit 73.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@abhinavkrin abhinavkrin force-pushed the refactor/custom-emoji-update branch from f4758aa to e5f224b Compare July 29, 2024 08:31
@abhinavkrin abhinavkrin marked this pull request as ready for review July 29, 2024 10:04
ricardogarim
ricardogarim previously approved these changes Jul 29, 2024
Copy link
Member

@MarcosSpessatto MarcosSpessatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some API tests to cover this?

Also, can we rewrite the PR title to be clearer?

@abhinavkrin
Copy link
Member Author

Can we add some API tests to cover this?

Also, can we rewrite the PR title to be clearer?

We already have tests for the emoji-custom endpoint. I will be adding tests along with my next pr for the fix.

@abhinavkrin abhinavkrin modified the milestones: 6.12, 6.11 Jul 29, 2024
@MarcosSpessatto MarcosSpessatto changed the title refactor: insertOrUpdateEmoji uploadEmojiCustom emoji-custom refactor: refactor custom-emoji functions out of meteor methods Jul 30, 2024
@abhinavkrin abhinavkrin dismissed stale reviews from MarcosSpessatto and ricardogarim via fb311c4 July 30, 2024 13:00
@scuciatto scuciatto modified the milestones: 6.11, 6.12 Jul 30, 2024
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
Signed-off-by: Abhinav Kumar <abhinav@avitechlab.com>
@abhinavkrin abhinavkrin force-pushed the refactor/custom-emoji-update branch from ff62710 to 3192f24 Compare August 6, 2024 10:02
@dougfabris dougfabris changed the title refactor: refactor custom-emoji functions out of meteor methods refactor: custom-emoji functions out of meteor methods Aug 6, 2024
@MarcosSpessatto MarcosSpessatto added the stat: QA assured Means it has been tested and approved by a company insider label Aug 8, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 8, 2024
@kodiakhq kodiakhq bot merged commit 6a7570b into develop Aug 8, 2024
48 checks passed
@kodiakhq kodiakhq bot deleted the refactor/custom-emoji-update branch August 8, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot modify custom emoji without re-uploading it
5 participants