Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Livechat): After Registration Triggers showing in wrong screen #32928

Merged
merged 7 commits into from
Jul 29, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 29, 2024

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Jul 29, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.12.0, but it targets 6.11.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 58cb8a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/livechat Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/ddp-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.72%. Comparing base (1a0377b) to head (58cb8a1).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32928      +/-   ##
===========================================
- Coverage    55.72%   55.72%   -0.01%     
===========================================
  Files         2637     2637              
  Lines        57399    57399              
  Branches     11892    11892              
===========================================
- Hits         31984    31983       -1     
+ Misses       22709    22704       -5     
- Partials      2706     2712       +6     
Flag Coverage Δ
e2e 54.38% <ø> (+0.01%) ⬆️
unit 72.37% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@MartinSchoeler MartinSchoeler changed the title test: refactor After Registration Triggers fix(Livechat): After Registration Triggers showing in wrong screen Jul 29, 2024
@MartinSchoeler MartinSchoeler marked this pull request as ready for review July 29, 2024 18:53
@MartinSchoeler MartinSchoeler requested review from a team as code owners July 29, 2024 18:53
@ggazzo ggazzo added this to the 6.12 milestone Jul 29, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 29, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 29, 2024
@MartinSchoeler MartinSchoeler removed the stat: ready to merge PR tested and approved waiting for merge label Jul 29, 2024
@ggazzo ggazzo merged commit a0ad916 into develop Jul 29, 2024
44 checks passed
@ggazzo ggazzo deleted the test/omni-triggers branch July 29, 2024 19:46
gabriellsh added a commit that referenced this pull request Jul 31, 2024
…ove/threadMetrics

* 'develop' of github.com:RocketChat/Rocket.Chat: (26 commits)
  chore: Bump rocket.chat to 6.12.0-develop (#32936)
  test: Move Jest configuration to a package of presets (#32802)
  chore: bump turbo (#32938)
  feat: New users page deactivated tab and active tab ui (#32032)
  chore: bump traefik (#32892)
  test: fix flaky test `Archive department` (#32933)
  fix(Livechat): `After Registration Triggers` showing in wrong screen (#32928)
  refactor: Remove deprecated `Options.AvatarSize` constant (#32909)
  chore: improve `on login` cached collection (#32929)
  i18n: Rocket.Chat language update from Lingohub 🤖 on 2024-07-25Z (#32908)
  refactor: Circular imports (#32885)
  regression: notify user properly on logout (#32920)
  chore(client): stop replacing  `Meteor.user` (#32910)
  regression: Messagebox sending message instead of just selecting popup suggestion (#32890)
  refactor: move broadcastMessageFromData to notifyListener (#32843)
  chore: prevent destructuring _id of deleted users (#32899)
  ci: increase kernel limits (#32902)
  ci: lint issues
  Release 6.10.1
  fix: imported fixes (#32894)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants