-
Notifications
You must be signed in to change notification settings - Fork 12.1k
chore: Use updater in saveUser
file
#32993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #32993 +/- ##
========================================
Coverage 59.19% 59.19%
========================================
Files 2821 2821
Lines 67633 67633
Branches 15048 15048
========================================
Hits 40033 40033
Misses 24784 24784
Partials 2816 2816
Flags with carried forward coverage won't be shown. Click here to find out more. |
@matheusbsilva137 the task linked doesn't seem to relate that much with what you're doing here. Maybe this needs its own task? |
…nto chore/save-user-ts-conversion
saveUser
file to TSsaveUser
file
|
We converted Feel free to review it again, everyone! (Please check the PR description for details on what I'm changing in this PR) |
Proposed changes (including videos or screenshots)
saveUser
file to avoid multiple DB trips;IUserSettings
type to have an optionalprofile
, as set through the API;settings
andlanguage
params in theusers.update
endpoint (those were already being handled by thesaveUser
function, but were not accepted by the endpoint -- so they could only be updated using the Meteor method);settings
param in theusers.create
endpoint (which was already being handled by thesaveUser
function, but was not accepted by the endpoint -- so it could only be created using the Meteor method).Issue(s)
Steps to test or reproduce
Further comments
CORE-734