refactor: Reactions set/unset

[KevLehman]

Proposed changes (including videos or screenshots)

• Refactors chat.react endpoint to remove check for message (executeSetReaction already does it)
• Refactors executeSetReaction to perform emoji & reactions check before all DB calls
• Refactors executeSetReaction to use new countByNameOrAlias query instead of a find().count()
• Refactors executeSetReaction to only request the required data when requesting room from DB
• Refactor setReaction to not await for callbacks (we don't need the return value anyways)
• Refactor setReaction to notify of room changed at the end of the function (instead of next to every update). This doesn't gain any perf, but looks better (and also fixes a missing notify).
• Added unit tests for all functions (except the meteor.methods call...)

Issue(s)

https://rocketchat.atlassian.net/browse/CORE-597

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 1accdaf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.93%. Comparing base (6a3c25c) to head (9a2fc13).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #32994      +/-   ##
===========================================
+ Coverage    59.85%   59.93%   +0.08%     
===========================================
  Files         2554     2556       +2     
  Lines        63008    63400     +392     
  Branches     14129    14246     +117     
===========================================
+ Hits         37711    37998     +287     
- Misses       22890    22969      +79     
- Partials      2407     2433      +26     

Flag	Coverage Δ
unit	77.20% <100.00%> (+0.05%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[kodiakhq]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

[github-actions]

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-19 23:58 UTC

everything done