Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve omni queue metrics query #33159

Merged
merged 8 commits into from
Sep 3, 2024
Merged

Conversation

sampaiodiego
Copy link
Member

@sampaiodiego sampaiodiego commented Aug 26, 2024

Proposed changes (including videos or screenshots)

The results should be the same but the pipeline structure is better for consuming less memory between stages.

Although the commits don't show it, I have added a few test cases for the endpoints that uses the query. I have then ran the tests against the old query and the new query.

Issue(s)

OPI-40

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Aug 26, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 0ed4cde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.33%. Comparing base (9e7cc89) to head (0ed4cde).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33159   +/-   ##
========================================
  Coverage    59.33%   59.33%           
========================================
  Files         2546     2546           
  Lines        63242    63235    -7     
  Branches     14217    14214    -3     
========================================
- Hits         37525    37521    -4     
+ Misses       23015    23014    -1     
+ Partials      2702     2700    -2     
Flag Coverage Δ
unit 75.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@sampaiodiego sampaiodiego force-pushed the improve-queue-query branch 3 times, most recently from e627bd5 to ba18fc5 Compare September 1, 2024 23:42
@sampaiodiego sampaiodiego marked this pull request as ready for review September 2, 2024 13:17
@sampaiodiego sampaiodiego requested review from a team as code owners September 2, 2024 13:17
ggazzo
ggazzo previously approved these changes Sep 2, 2024
KevLehman
KevLehman previously approved these changes Sep 2, 2024
@sampaiodiego sampaiodiego dismissed stale reviews from KevLehman and ggazzo via 0ed4cde September 2, 2024 23:03
@sampaiodiego sampaiodiego added the stat: QA assured Means it has been tested and approved by a company insider label Sep 2, 2024
@sampaiodiego sampaiodiego added this to the 6.12 milestone Sep 2, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 2, 2024
@kodiakhq kodiakhq bot merged commit 304bc6d into develop Sep 3, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the improve-queue-query branch September 3, 2024 00:49
ggazzo pushed a commit that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants