Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(i18n): Increase the adoption of react-i18next - Phase 1 #33175

Merged
merged 6 commits into from
Sep 13, 2024

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Aug 28, 2024

Proposed changes (including videos or screenshots)

It mainly replaces useTranslation from @rocket.chat/ui-contexts with useTranslation from react-i18next.

Issue(s)

Steps to test or reproduce

Further comments

Copy link

changeset-bot bot commented Aug 28, 2024

⚠️ No Changeset found

Latest commit: f88af84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Aug 28, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@tassoevan tassoevan force-pushed the refactor/i18next branch 2 times, most recently from b931c51 to 8134c47 Compare September 3, 2024 19:39
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 59.68%. Comparing base (811e2cb) to head (f88af84).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33175      +/-   ##
===========================================
- Coverage    59.76%   59.68%   -0.08%     
===========================================
  Files         2551     2551              
  Lines        63118    62819     -299     
  Branches     14116    14115       -1     
===========================================
- Hits         37720    37496     -224     
+ Misses       22982    22908      -74     
+ Partials      2416     2415       -1     
Flag Coverage Δ
unit 76.91% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan changed the title refactor/i18next refactor(i18n): Increase the adoption of react-i18next - Phase 1 Sep 4, 2024
@tassoevan tassoevan added this to the 6.13 milestone Sep 4, 2024
@tassoevan tassoevan marked this pull request as ready for review September 10, 2024 23:50
@tassoevan tassoevan requested review from a team as code owners September 10, 2024 23:50
Copy link
Contributor

github-actions bot commented Sep 12, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-09-13 12:01 UTC

ggazzo
ggazzo previously approved these changes Sep 12, 2024
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants