-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(i18n): Increase the adoption of react-i18next
- Phase 1
#33175
Conversation
|
Looks like this PR is ready to merge! 🎉 |
b931c51
to
8134c47
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33175 +/- ##
===========================================
- Coverage 59.76% 59.68% -0.08%
===========================================
Files 2551 2551
Lines 63118 62819 -299
Branches 14116 14115 -1
===========================================
- Hits 37720 37496 -224
+ Misses 22982 22908 -74
+ Partials 2416 2415 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
8134c47
to
c93077f
Compare
refactor/i18next
react-i18next
- Phase 1
c93077f
to
656c756
Compare
656c756
to
6713144
Compare
|
6713144
to
4559c85
Compare
4559c85
to
f88af84
Compare
Proposed changes (including videos or screenshots)
It mainly replaces
useTranslation
from@rocket.chat/ui-contexts
withuseTranslation
fromreact-i18next
.Issue(s)
Steps to test or reproduce
Further comments