-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New endpoint for listing rooms & discussions from teams #33177
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: fdfd5ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33177 +/- ##
========================================
Coverage 59.70% 59.70%
========================================
Files 2551 2551
Lines 62792 62792
Branches 14102 14102
========================================
Hits 37492 37492
Misses 22893 22893
Partials 2407 2407
Flags with carried forward coverage won't be shown. Click here to find out more. |
packages/rest-typings/src/v1/teams/TeamsListRoomsAndDiscussions.ts
Outdated
Show resolved
Hide resolved
c80a40f
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
59b5c64
to
3fac30c
Compare
@KevLehman @MarcosSpessatto I just rebased against |
Thanks @ggazzo ! @MarcosSpessatto @sampaiodiego :whip: |
@sampaiodiego , wanna take a look again? 😬 |
|
Proposed changes (including videos or screenshots)
teams.listChildren
Issue(s)
https://rocketchat.atlassian.net/browse/SIDE-145
Steps to test or reproduce
Further comments
Perf metrics!
Team with 5 rooms, 1 discussion, no filter
Team with 5 rooms, 1 discussion, filter "t"