-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resolve avatar download issue on setUsername by refining service selection logic #33193
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 7a5bb19 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #33193 +/- ##
===========================================
+ Coverage 59.70% 59.74% +0.03%
===========================================
Files 2551 2552 +1
Lines 62792 62906 +114
Branches 14102 14129 +27
===========================================
+ Hits 37492 37581 +89
- Misses 22893 22917 +24
- Partials 2407 2408 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way we could add some tests here?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a further optimization, when calling setUsername
we don't need to call getAvatarSuggestionForUser
which will fetch avatar for EVERY SERVICE available, we just need the first one =)
As per CORE-650, this pull request addresses the issue where the avatar blob image was not being correctly set in the
setUserAvatar
method, resulting in an undefined error for the user. The root cause was identified as incorrect handling of avatar service selection, which led to errors during the avatar setting process.Key changes: