Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error on sendmessage stub #33317

Merged
merged 2 commits into from
Sep 19, 2024
Merged

fix: error on sendmessage stub #33317

merged 2 commits into from
Sep 19, 2024

Conversation

ggazzo
Copy link
Member

@ggazzo ggazzo commented Sep 19, 2024

Exception while simulating the effect of invoking 'sendMessage' TypeError: Cannot read properties of undefined (reading 'name')
    at eval (useAnalyticsEventTracking.ts:59:43)
    at i.runOne (callbacksBase.ts:59:26)
    at callbacksBase.ts:68:24
    at callbacksBase.ts:76:5

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 19, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: fe10246

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ggazzo ggazzo added this to the 6.13 milestone Sep 19, 2024
@ggazzo ggazzo changed the title chore: error on sendmessage stub fix: error on sendmessage stub Sep 19, 2024
Copy link
Contributor

github-actions bot commented Sep 19, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-09-19 13:42 UTC

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Sep 19, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Sep 19, 2024
@ggazzo ggazzo marked this pull request as ready for review September 19, 2024 02:40
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.85%. Comparing base (d0595a3) to head (fe10246).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33317      +/-   ##
===========================================
- Coverage    59.85%   59.85%   -0.01%     
===========================================
  Files         2554     2554              
  Lines        63008    63007       -1     
  Branches     14129    14129              
===========================================
- Hits         37711    37710       -1     
  Misses       22890    22890              
  Partials      2407     2407              
Flag Coverage Δ
unit 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@kodiakhq kodiakhq bot merged commit a541f64 into develop Sep 19, 2024
52 checks passed
@kodiakhq kodiakhq bot deleted the chore/sendMessage-stub branch September 19, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants