Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: page warning before leave/reload while a call is ongoing #33404

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

aleksandernsilva
Copy link
Contributor

@aleksandernsilva aleksandernsilva commented Sep 30, 2024

Proposed changes (including videos or screenshots)

Users should now be warned when trying to leave or reloading the page during calls.

Screenshot 2024-10-02 at 10 03 11

Screenshot 2024-10-02 at 10 03 01

Issue(s)

VOIP-98

Steps to test or reproduce

  • Open the application
  • Configure Voip for team collab and user extension
  • Start a call
  • Try to leave or reload page

Further comments

Copy link
Contributor

dionisio-bot bot commented Sep 30, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Sep 30, 2024

⚠️ No Changeset found

Latest commit: ee48cdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 30, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-07 18:30 UTC

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.57%. Comparing base (d661782) to head (ee48cdd).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33404   +/-   ##
========================================
  Coverage    58.57%   58.57%           
========================================
  Files         2737     2737           
  Lines        65763    65763           
  Branches     14826    14826           
========================================
  Hits         38521    38521           
  Misses       24463    24463           
  Partials      2779     2779           
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Base automatically changed from feat/freeswitch-6-12 to develop September 30, 2024 20:50
@aleksandernsilva aleksandernsilva force-pushed the feat/voip-before-unload-alert branch from cd8dfb2 to ba0f47d Compare October 1, 2024 23:13
@aleksandernsilva aleksandernsilva marked this pull request as ready for review October 2, 2024 14:04
@aleksandernsilva aleksandernsilva changed the title feat: added warning before refresh while call is ongoing feat: page warning before leave/reload while a call is ongoing Oct 2, 2024
Copy link
Contributor

@tassoevan tassoevan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It think there is one situation when the onBeforeUnload might not get detached correctly. Imagine a situation where onCallEstablished was called (attaching it) but then an error is throw from a component; VoipProvider is unmounted, the error is caught at AppRoot's error boundary, and the onBeforeUnload will be attached to window yet. Maybe an extra call to window.removeEventListener('beforeunload', onBeforeUnload); at the effect clean up function will prevent it from happening.

@aleksandernsilva aleksandernsilva added this to the 6.14 milestone Oct 7, 2024
@aleksandernsilva aleksandernsilva added the stat: QA assured Means it has been tested and approved by a company insider label Oct 7, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 7, 2024
@kodiakhq kodiakhq bot merged commit 34879cc into develop Oct 7, 2024
50 checks passed
@kodiakhq kodiakhq bot deleted the feat/voip-before-unload-alert branch October 7, 2024 18:30
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants