fix: Don't return users with E2ESuggestedKey set when selecting users to provide E2EKey
#33405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning key exchange
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: a698950 The changes in this PR will be included in the next version bump. This PR includes changesets to release 33 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33405 +/- ##
========================================
Coverage 58.58% 58.59%
========================================
Files 2737 2737
Lines 65679 65708 +29
Branches 14824 14826 +2
========================================
+ Hits 38479 38500 +21
- Misses 24421 24429 +8
Partials 2779 2779
Flags with carried forward coverage won't be shown. Click here to find out more. |
dionisio-bot
bot
added
stat: ready to merge
sampaiodiego
reviewed
Oct 8, 2024
sampaiodiego
approved these changes
Oct 8, 2024
kodiakhq
bot
deleted the
fix/avoid-suggesting-keys-to-users-with-a-suggested-key
branch
This was referenced Oct 20, 2024
Closed
Closed
Merged
abhinavkrin
pushed a commit
that referenced
this pull request
Oct 25, 2024
…rs to provide E2EKey (#33405)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This should prevent an issue where a user may receive an indefinite amount of "suggested keys" from all the users on a room even when a user already suggested a key for them, duplicating the work.
Now, the endpoint that returns users waiting for keys will return only users that don't have neither
E2EKeynorE2ESuggestedKey.Issue(s)
https://rocketchat.atlassian.net/browse/E2EE2-72
Steps to test or reproduce
Further comments