-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: e2ee mention setting update #33419
Conversation
🦋 Changeset detectedLatest commit: b5cfba5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Looks like this PR is ready to merge! 🎉 |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.0.0 #33419 +/- ##
================================================
Coverage ? 74.64%
================================================
Files ? 437
Lines ? 20485
Branches ? 5252
================================================
Hits ? 15291
Misses ? 4582
Partials ? 612
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed with Hugo via DM that this change gets propagated to the cached collection accordingly, 💯
The merge-base changed after approval.
d1aa5f9
to
374979f
Compare
fb25552
to
99c04b1
Compare
bfefe41
to
204272c
Compare
01c2490
to
b5cfba5
Compare
Proposed changes (including videos or screenshots)
Change the default value of
E2E_Enabled_Mentions
to true to always accept mentions in E2EE messagesIssue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/E2EE2-71