Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: e2ee mention setting update #33419

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

hugocostadev
Copy link
Contributor

@hugocostadev hugocostadev commented Oct 2, 2024

Proposed changes (including videos or screenshots)

Change the default value of E2E_Enabled_Mentions to true to always accept mentions in E2EE messages

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/E2EE2-71

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: b5cfba5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

dionisio-bot bot commented Oct 2, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@hugocostadev hugocostadev changed the base branch from develop to release-7.0.0 October 2, 2024 14:53
Copy link
Contributor

github-actions bot commented Oct 2, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33419/
on branch gh-pages at 2024-10-15 01:27 UTC

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-7.0.0@204272c). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #33419   +/-   ##
================================================
  Coverage                 ?   74.64%           
================================================
  Files                    ?      437           
  Lines                    ?    20485           
  Branches                 ?     5252           
================================================
  Hits                     ?    15291           
  Misses                   ?     4582           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.64% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@hugocostadev hugocostadev marked this pull request as ready for review October 2, 2024 16:31
@hugocostadev hugocostadev requested review from a team as code owners October 2, 2024 16:31
@hugocostadev hugocostadev modified the milestones: 7., 7.0 Oct 2, 2024
tassoevan
tassoevan previously approved these changes Oct 3, 2024
@hugocostadev hugocostadev added the stat: QA assured Means it has been tested and approved by a company insider label Oct 3, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 3, 2024
@hugocostadev hugocostadev removed stat: ready to merge PR tested and approved waiting for merge stat: QA assured Means it has been tested and approved by a company insider labels Oct 3, 2024
KevLehman
KevLehman previously approved these changes Oct 3, 2024
Copy link
Contributor

@KevLehman KevLehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with Hugo via DM that this change gets propagated to the cached collection accordingly, 💯

@ggazzo ggazzo dismissed stale reviews from KevLehman and tassoevan October 8, 2024 17:42

The merge-base changed after approval.

@ggazzo ggazzo requested a review from a team as a code owner October 8, 2024 17:42
@sampaiodiego sampaiodiego force-pushed the release-7.0.0 branch 2 times, most recently from d1aa5f9 to 374979f Compare October 9, 2024 17:43
@ggazzo ggazzo force-pushed the release-7.0.0 branch 3 times, most recently from fb25552 to 99c04b1 Compare October 11, 2024 18:01
@jessicaschelly jessicaschelly added the stat: QA assured Means it has been tested and approved by a company insider label Oct 11, 2024
@ggazzo ggazzo force-pushed the release-7.0.0 branch 4 times, most recently from bfefe41 to 204272c Compare October 15, 2024 00:45
@ggazzo ggazzo force-pushed the chore/e2ee-mention-setting-update branch from 01c2490 to b5cfba5 Compare October 15, 2024 00:49
@ggazzo ggazzo merged commit 11a47b6 into release-7.0.0 Oct 15, 2024
8 of 9 checks passed
@ggazzo ggazzo deleted the chore/e2ee-mention-setting-update branch October 15, 2024 00:49
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
ggazzo pushed a commit that referenced this pull request Oct 17, 2024
This was referenced Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants