Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: marketplace add-on components #33483

Merged
merged 27 commits into from
Oct 18, 2024
Merged

feat: marketplace add-on components #33483

merged 27 commits into from
Oct 18, 2024

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Oct 7, 2024

Proposed changes (including videos or screenshots)

New components added to marketplace pages:

Add-on tag:
image

Add-on required modal:
image

Add-on callout in app info page:
image

Issue(s)

Steps to test or reproduce

Further comments

Depends on #33433

ADD-10

ADD-11
ADD-12

Copy link
Contributor

dionisio-bot bot commented Oct 7, 2024

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 7, 2024

🦋 Changeset detected

Latest commit: c682e3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 37 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/i18n
@rocket.chat/mock-providers Patch
@rocket.chat/ui-contexts Major
@rocket.chat/web-ui-registration Major
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/ui-client Major
@rocket.chat/ui-voip Major
@rocket.chat/uikit-playground Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-video-conf Major
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/model-typings Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 7, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33483/
on branch gh-pages at 2024-10-18 21:23 UTC

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.88%. Comparing base (34ed9ad) to head (c682e3f).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #33483   +/-   ##
========================================
  Coverage    74.88%   74.88%           
========================================
  Files          473      473           
  Lines        20810    20810           
  Branches      5314     5314           
========================================
  Hits         15583    15583           
  Misses        4602     4602           
  Partials       625      625           
Flag Coverage Δ
unit 74.88% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@milton-rucks milton-rucks added this to the 6.14 milestone Oct 9, 2024
@tiagoevanp tiagoevanp changed the title feat: Apps add-on feat: Marketplace add-on components Oct 15, 2024
@tiagoevanp tiagoevanp marked this pull request as ready for review October 15, 2024 19:07
@tiagoevanp tiagoevanp requested a review from a team as a code owner October 15, 2024 19:07
MartinSchoeler
MartinSchoeler previously approved these changes Oct 16, 2024
yash-rajpal
yash-rajpal previously approved these changes Oct 16, 2024
Copy link
Member

@yash-rajpal yash-rajpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoevanp tiagoevanp dismissed stale reviews from yash-rajpal and MartinSchoeler via bd80b7f October 16, 2024 20:00
@ggazzo ggazzo modified the milestones: 6.14, 7.0 Oct 17, 2024
@d-gubert d-gubert changed the title feat: Marketplace add-on components feat: marketplace add-on components Oct 18, 2024
@d-gubert d-gubert added the stat: QA assured Means it has been tested and approved by a company insider label Oct 18, 2024
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Oct 18, 2024
@d-gubert d-gubert dismissed tassoevan’s stale review October 18, 2024 20:52

Changes have been applied

@kodiakhq kodiakhq bot merged commit e3dac4a into develop Oct 18, 2024
51 checks passed
@kodiakhq kodiakhq bot deleted the feat/apps-add-on branch October 18, 2024 22:12
This was referenced Oct 20, 2024
abhinavkrin pushed a commit that referenced this pull request Oct 25, 2024
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com>
Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants