-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: marketplace add-on components #33483
Conversation
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: c682e3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #33483 +/- ##
========================================
Coverage 74.88% 74.88%
========================================
Files 473 473
Lines 20810 20810
Branches 5314 5314
========================================
Hits 15583 15583
Misses 4602 4602
Partials 625 625
Flags with carried forward coverage won't be shown. Click here to find out more. |
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppDetails/AppDetails.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppDetails/AppDetails.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppDetails/AppDetails.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppDetails/AppDetails.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/AppsList/AddonRequiredModal.tsx
Outdated
Show resolved
Hide resolved
apps/meteor/client/views/marketplace/AppDetailsPage/tabs/AppStatus/AppStatus.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bd80b7f
Co-authored-by: Tasso Evangelista <tasso.evangelista@rocket.chat>
686494b
to
15d7fda
Compare
Co-authored-by: Douglas Gubert <1810309+d-gubert@users.noreply.github.com> Co-authored-by: Tasso Evangelista <2263066+tassoevan@users.noreply.github.com>
Proposed changes (including videos or screenshots)
New components added to marketplace pages:
Add-on tag:
Add-on required modal:
Add-on callout in app info page:
Issue(s)
Steps to test or reproduce
Further comments
Depends on #33433
ADD-10
ADD-11
ADD-12