Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds reactivity to contact history message list #33505

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

dougfabris
Copy link
Member

@dougfabris dougfabris commented Oct 8, 2024

Proposed changes (including videos or screenshots)

Related to: #32845

Kapture 2024-10-08 at 19 17 35

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 8, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 8, 2024

⚠️ No Changeset found

Latest commit: 310b540

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-10-09 12:33 UTC

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.48%. Comparing base (3b4509f) to head (310b540).
Report is 1 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/single-contact-id   #33505   +/-   ##
=======================================================
  Coverage                   58.48%   58.48%           
=======================================================
  Files                        2743     2743           
  Lines                       65720    65718    -2     
  Branches                    14777    14777           
=======================================================
  Hits                        38435    38435           
+ Misses                      24533    24531    -2     
  Partials                     2752     2752           
Flag Coverage Δ
unit 75.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@dougfabris dougfabris marked this pull request as ready for review October 8, 2024 23:56
@dougfabris dougfabris requested a review from a team as a code owner October 8, 2024 23:56
@dougfabris dougfabris merged commit 6f62f24 into feat/single-contact-id Oct 9, 2024
51 checks passed
@dougfabris dougfabris deleted the chore/contact-history-reactivity branch October 9, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants