Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: erase conflict on update #33638

Merged

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Oct 18, 2024

Proposed changes (including videos or screenshots)

Adds a new property to remove conflicting fields. The wipeConflicts: true should be passed when the update are being performed to solve all conflicts.

Issue(s)

Steps to test or reproduce

Further comments

Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: c73d427

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tapiarafael tapiarafael marked this pull request as ready for review October 18, 2024 02:16
@tapiarafael tapiarafael requested review from a team as code owners October 18, 2024 02:16
Copy link
Contributor

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33638/
on branch gh-pages at 2024-10-18 02:33 UTC

@pierre-lehnen-rc pierre-lehnen-rc force-pushed the chore/contact-conflict-update branch from 2fe2ad9 to c73d427 Compare October 18, 2024 04:45
@pierre-lehnen-rc pierre-lehnen-rc merged commit 89ddf51 into feat/single-contact-id Oct 18, 2024
46 of 53 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the chore/contact-conflict-update branch October 18, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants