-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Contact email and phone validation not working properly #33653
fix: Contact email and phone validation not working properly #33653
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33653 +/- ##
===========================================================
+ Coverage 58.43% 74.42% +15.98%
===========================================================
Files 2744 475 -2269
Lines 66280 21050 -45230
Branches 15001 5358 -9643
===========================================================
- Hits 38732 15666 -23066
+ Misses 24717 4743 -19974
+ Partials 2831 641 -2190
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SCI-99