-
Notifications
You must be signed in to change notification settings - Fork 11.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove appId from visitor search #33654
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/single-contact-id #33654 +/- ##
=======================================================
Coverage 74.42% 74.42%
=======================================================
Files 475 475
Lines 21050 21050
Branches 5358 5358
=======================================================
Hits 15666 15666
Misses 4743 4743
Partials 641 641
Flags with carried forward coverage won't be shown. Click here to find out more. |
6629729
into
feat/single-contact-id
Proposed changes (including videos or screenshots)
Fixes the problem of not finding the visitor when the interaction with the UiKit comes from the widget since the appId refers to the interaction with the button, but the visitor does not necessarily have the app as the source.
Issue(s)
Steps to test or reproduce
Further comments
Introduced by #33569