Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove appId from visitor search #33654

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

tapiarafael
Copy link
Member

@tapiarafael tapiarafael commented Oct 18, 2024

Proposed changes (including videos or screenshots)

Fixes the problem of not finding the visitor when the interaction with the UiKit comes from the widget since the appId refers to the interaction with the button, but the visitor does not necessarily have the app as the source.

Issue(s)

Steps to test or reproduce

Further comments

Introduced by #33569

Copy link
Contributor

dionisio-bot bot commented Oct 18, 2024

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Oct 18, 2024

⚠️ No Changeset found

Latest commit: 3376fd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@matheusbsilva137 matheusbsilva137 added this to the 7.0 milestone Oct 18, 2024
Copy link
Contributor

github-actions bot commented Oct 18, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33654/
on branch gh-pages at 2024-10-18 17:30 UTC

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.42%. Comparing base (504e084) to head (3376fd5).
Report is 23 commits behind head on feat/single-contact-id.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/single-contact-id   #33654   +/-   ##
=======================================================
  Coverage                   74.42%   74.42%           
=======================================================
  Files                         475      475           
  Lines                       21050    21050           
  Branches                     5358     5358           
=======================================================
  Hits                        15666    15666           
  Misses                       4743     4743           
  Partials                      641      641           
Flag Coverage Δ
unit 74.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc merged commit 6629729 into feat/single-contact-id Oct 18, 2024
44 of 50 checks passed
@pierre-lehnen-rc pierre-lehnen-rc deleted the fix/ui-kit-visitor branch October 18, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants